Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-5739][VL] Fix ShuffleReaderMetrics deserializeTime always is zero #5738

Merged
merged 1 commit into from
May 14, 2024

Conversation

zjuwangg
Copy link
Contributor

@zjuwangg zjuwangg commented May 14, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #5739)
Fix ShuffleReaderMetrics deserializeTime always is zero

How was this patch tested?

no need

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zjuwangg zjuwangg changed the title Fix ShuffleReaderMetrics deserializeTime always is zero [GLUTEN-5739]Fix ShuffleReaderMetrics deserializeTime always is zero May 14, 2024
Copy link

#5739

@zjuwangg
Copy link
Contributor Author

@zuochunwei please help to have a look

Copy link
Contributor

@Yohahaha Yohahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thank you!

@Yohahaha Yohahaha changed the title [GLUTEN-5739]Fix ShuffleReaderMetrics deserializeTime always is zero [GLUTEN-5739][VL] Fix ShuffleReaderMetrics deserializeTime always is zero May 14, 2024
@Yohahaha Yohahaha merged commit 4907f25 into apache:main May 14, 2024
46 checks passed
@zjuwangg zjuwangg deleted the m_fixShuffleReaderMetrics branch May 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShuffleReaderMetrics deserializeTime seems always is zero
3 participants